From b12bc5849432ba8ec4026e78a86fb927754fd363 Mon Sep 17 00:00:00 2001 From: Frantisek Hrbata Date: Fri, 9 Jan 2026 11:09:41 +0100 Subject: [PATCH 1/2] fix(cmake): disable MINIMAL_BUILD build property if COMPONENTS is defined The MINIMAL_BUILD build property and the COMPONENTS variable are both used to determine the initial component list for the build. Currently, if the COMPONENTS variable is set, the MINIMAL_BUILD logic is ignored during component selection, but the MINIMAL_BUILD build property remains set. This leads to an inconsistent state where menuconfig displays information indicating MINIMAL_BUILD is active, even though it was ignored in favor of the COMPONENTS variable. Fix this by setting the MINIMAL_BUILD property to OFF if the COMPONENTS variable is used. Signed-off-by: Frantisek Hrbata --- tools/cmake/project.cmake | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/cmake/project.cmake b/tools/cmake/project.cmake index 72504c061c..1194687d0b 100644 --- a/tools/cmake/project.cmake +++ b/tools/cmake/project.cmake @@ -503,6 +503,7 @@ function(__project_init components_var test_components_var) if(DEFINED COMPONENTS) message(WARNING "The MINIMAL_BUILD property is disregarded because the COMPONENTS variable is defined.") set(minimal_build OFF) + idf_build_set_property(MINIMAL_BUILD OFF) else() set(COMPONENTS main ${TEST_COMPONENTS}) set(minimal_build ON) From a2a3a102a2f256cecea197e6004b116e7a105be4 Mon Sep 17 00:00:00 2001 From: Frantisek Hrbata Date: Fri, 9 Jan 2026 13:18:25 +0100 Subject: [PATCH 2/2] fix(ci): add rules.yml to check-tools-files-patterns pre-commit hook pattern If `.gitlab/ci/rules\.yml` is changed, make sure the `check-tools-files-patterns` pre-commit hooks is triggered to verify that all `tools/*` files are covered by rules.yml. Signed-off-by: Frantisek Hrbata --- .pre-commit-config.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index b6b906cee0..2141eb025f 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -137,7 +137,7 @@ repos: name: Check tools dir files patterns entry: tools/ci/check_tools_files_patterns.py language: python - files: '^tools/.+' + files: '^(tools/.+|.gitlab/ci/rules\.yml)' additional_dependencies: - PyYAML == 5.3.1 pass_filenames: false