From 20f468167a2a64a2d6fa87a00a8a8ac05fddeecc Mon Sep 17 00:00:00 2001 From: konsti Date: Thu, 15 Jan 2026 18:23:50 +0100 Subject: [PATCH] Log when response arrives (#17488) Looking at #17485, I noticed we don't log when a request finishes, making the log harder to read than necessary. Example new log message: ``` TRACE Received response for revalidation request with status 304 Not Modified for: https://pypi.org/simple/idna/ ``` --- crates/uv-client/src/cached_client.rs | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/crates/uv-client/src/cached_client.rs b/crates/uv-client/src/cached_client.rs index 05f1f91b2..5e2428de2 100644 --- a/crates/uv-client/src/cached_client.rs +++ b/crates/uv-client/src/cached_client.rs @@ -541,6 +541,11 @@ impl CachedClient { .instrument(info_span!("revalidation_request", url = url.as_str())) .await .map_err(|err| Error::from_reqwest_middleware(url.clone(), err))?; + trace!( + "Received response for revalidation request with status {} for: {}", + response.status(), + url + ); // Check for HTTP error status and extract problem details if available if let Err(status_error) = response.error_for_status_ref() { @@ -604,13 +609,18 @@ impl CachedClient { cache_control: CacheControl<'_>, ) -> Result<(Response, Option>), Error> { let url = DisplaySafeUrl::from_url(req.url().clone()); - trace!("Sending fresh {} request for {}", req.method(), url); + debug!("Sending fresh {} request for: {}", req.method(), url); let cache_policy_builder = CachePolicyBuilder::new(&req); let mut response = self .0 .execute(req) .await .map_err(|err| Error::from_reqwest_middleware(url.clone(), err))?; + trace!( + "Received response for fresh request with status {} for: {}", + response.status(), + url + ); // If the user set a custom `Cache-Control` header, override it. if let CacheControl::Override(header) = cache_control {