From 372cfc00bf0d13206f62fef5e8601034b3115444 Mon Sep 17 00:00:00 2001 From: Charlie Marsh Date: Sat, 24 Feb 2024 16:42:46 -0500 Subject: [PATCH] Properly apply constraints in venv audit (#1956) ## Summary We were applying every constraint to every dependency. This is "harmless" in practice since this is just an optimization, but we thus had false negatives ~every time which could lead to wasted work. --- crates/uv-installer/src/site_packages.rs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/crates/uv-installer/src/site_packages.rs b/crates/uv-installer/src/site_packages.rs index 30633c162..207a9f24e 100644 --- a/crates/uv-installer/src/site_packages.rs +++ b/crates/uv-installer/src/site_packages.rs @@ -334,6 +334,10 @@ impl<'a> SitePackages<'a> { // Validate that the installed version satisfies the constraints. for constraint in constraints { + if constraint.name != requirement.name { + continue; + } + if !constraint.evaluate_markers(self.venv.interpreter().markers(), &[]) { continue; }