From 46a0ed7fa2ff9b3d28f5618610525ec2d8658f87 Mon Sep 17 00:00:00 2001 From: Charlie Marsh Date: Thu, 10 Oct 2024 01:05:51 +0200 Subject: [PATCH] Use comma-separated values for `UV_FIND_LINKS` (#8061) ## Summary These values can include spaces when passed on the command-line... Clap doesn't give us a way to provide a value separator for _only_ an environment variable (as is pip's behavior), so I think we're stuck using comma-separated for here right now. See, e.g., https://github.com/clap-rs/clap/discussions/3796. Closes #8057. --- crates/uv-cli/src/lib.rs | 1 - docs/configuration/environment.md | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/crates/uv-cli/src/lib.rs b/crates/uv-cli/src/lib.rs index 4f6bd465d..7e7b65bbc 100644 --- a/crates/uv-cli/src/lib.rs +++ b/crates/uv-cli/src/lib.rs @@ -3813,7 +3813,6 @@ pub struct IndexArgs { long, short, env = "UV_FIND_LINKS", - value_delimiter = ' ', value_parser = parse_flat_index, help_heading = "Index options" )] diff --git a/docs/configuration/environment.md b/docs/configuration/environment.md index cf29ad291..31bf07f88 100644 --- a/docs/configuration/environment.md +++ b/docs/configuration/environment.md @@ -7,7 +7,7 @@ uv accepts the following command-line arguments as environment variables: - `UV_EXTRA_INDEX_URL`: Equivalent to the `--extra-index-url` command-line argument. If set, uv will use this space-separated list of URLs as additional indexes when searching for packages. - `UV_FIND_LINKS`: Equivalent to the `--find-links` command-line argument. If set, uv will use this - space-separated list of additional locations to search for packages. + comma-separated list of additional locations to search for packages. - `UV_CACHE_DIR`: Equivalent to the `--cache-dir` command-line argument. If set, uv will use this directory for caching instead of the default cache directory. - `UV_NO_CACHE`: Equivalent to the `--no-cache` command-line argument. If set, uv will not use the