pioduino/uv
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Fix display of HTTP responses in trace logs for retry of errors (#13339)

Browse Source 
Follows https://github.com/astral-sh/uv/pull/13228

Closes https://github.com/astral-sh/uv/issues/13338

I recall some discussion (maybe around
https://github.com/astral-sh/uv/pull/4725) about how finding the source
may not work properly? I can't find it though.

Now, I tested this, e.g.:

```
❯ cargo run -q -- pip install anyio -vv --index-url https://download.pytorch.org/whl/torch/ --no-cache --reinstall
...
TRACE Considering retry of response HTTP 403 Forbidden for https://download.pytorch.org/whl/torch/anyio/
```

I lament that I didn't think of that as a testing method in the first
place :)
This commit is contained in:
Zanie Blue
2025-05-08 09:23:24 -05:00
committed by GitHub
parent 145fe4e7e3
commit 9a15240147
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/uv-client/src/base_client.rs
+2 -6
View File
@@ -481,14 +481,10 @@ impl RetryableStrategy for UvRetryableStrategy {
/// These cases should be safe to retry with [`Retryable::Transient`]. /// These cases should be safe to retry with [`Retryable::Transient`].
pub fn is_extended_transient_error(err: &dyn Error) -> bool { pub fn is_extended_transient_error(err: &dyn Error) -> bool {
// First, try to show a nice trace log // First, try to show a nice trace log
if let Some((Some(status), Some(url))) = find_source::<reqwest::Error>(&err) if let Some((Some(status), Some(url))) = find_source::<crate::WrappedReqwestError>(&err)
.map(|request_err| (request_err.status(), request_err.url())) .map(|request_err| (request_err.status(), request_err.url()))
{ {
let status = status trace!("Considering retry of response HTTP {status} for {url}");
.canonical_reason()
.map(|reason| format!(" HTTP {status} {reason} "))
.unwrap_or_else(|| format!(" HTTP {status} "));
trace!("Considering retry of {status} for {url}");
} else { } else {
trace!("Considering retry of error: {err:?}"); trace!("Considering retry of error: {err:?}");
} }