Charlie Marsh
a267a501b6
## Summary Some zip files can't be streamed; in particular, `rs-async-zip` doesn't support data descriptors right now (though it may in the future). This PR adds a fallback path for such zips that downloads the entire zip file to disk, then unzips it from disk (which gives us `Seek`). Closes https://github.com/astral-sh/uv/issues/2216. ## Test Plan `cargo run pip install --extra-index-url https://buf.build/gen/python hashb_foxglove_protocolbuffers_python==25.3.0.1.20240226043130+465630478360 --force-reinstall -n`
32 lines
1.1 KiB
Rust
32 lines
1.1 KiB
Rust
use std::{ffi::OsString, path::PathBuf};
|
|
|
|
#[derive(Debug, thiserror::Error)]
|
|
pub enum Error {
|
|
#[error(transparent)]
|
|
Zip(#[from] zip::result::ZipError),
|
|
#[error(transparent)]
|
|
AsyncZip(#[from] async_zip::error::ZipError),
|
|
#[error(transparent)]
|
|
Io(#[from] std::io::Error),
|
|
#[error("Unsupported archive type: {0}")]
|
|
UnsupportedArchive(PathBuf),
|
|
#[error(
|
|
"The top-level of the archive must only contain a list directory, but it contains: {0:?}"
|
|
)]
|
|
NonSingularArchive(Vec<OsString>),
|
|
#[error("The top-level of the archive must only contain a list directory, but it's empty")]
|
|
EmptyArchive,
|
|
}
|
|
|
|
impl Error {
|
|
/// Returns `true` if the error is due to the server not supporting HTTP streaming. Most
|
|
/// commonly, this is due to serving ZIP files with features that are incompatible with
|
|
/// streaming, like data descriptors.
|
|
pub fn is_http_streaming_unsupported(&self) -> bool {
|
|
matches!(
|
|
self,
|
|
Self::AsyncZip(async_zip::error::ZipError::FeatureNotSupported(_))
|
|
)
|
|
}
|
|
}
|