pioduino/esp-idf
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge branch 'bugfix/http_digest_arg_validation_v5.5' into 'release/v5.5'

Browse Source 
fix(esp_http_client): prevent out-of-bounds read in Digest auth (v5.5)

See merge request espressif/esp-idf!43901
This commit is contained in:
Aditya Patwardhan
2026-01-05 16:00:38 +05:30
parent 664882084c bbcc13be8b
commit 6d0a7a01ce
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
components/esp_http_client/lib/http_auth.c
+5 -4
View File
@@ -122,14 +122,15 @@ char *http_auth_digest(const char *username, const char *password, esp_http_auth
password == NULL ||
auth_data->nonce == NULL ||
auth_data->uri == NULL ||
auth_data->realm == NULL) {
auth_data->realm == NULL ||
auth_data->algorithm == NULL) {
return NULL;
}
int digest_size = MD5_MAX_LEN;
int (*digest_func)(char *digest, const char *fmt, ...) = md5_printf;
if (!memcmp(auth_data->algorithm, "SHA256", strlen("SHA256")) ||
!memcmp(auth_data->algorithm, "SHA-256", strlen("SHA-256"))) {
if (strcasecmp(auth_data->algorithm, "SHA256") == 0 ||
strcasecmp(auth_data->algorithm, "SHA-256") == 0) {
digest_size = SHA256_HEX_LEN;
digest_func = sha256_sprintf;
}
@@ -150,7 +151,7 @@ char *http_auth_digest(const char *username, const char *password, esp_http_auth
ESP_LOGD(TAG, "%s %s %s %s", "Digest", username, auth_data->realm, password);
if ((strcasecmp(auth_data->algorithm, "md5-sess") == 0) ||
(strcasecmp(auth_data->algorithm, "SHA256") == 0) ||
(strcasecmp(auth_data->algorithm, "md5-sess") == 0)) {
(strcasecmp(auth_data->algorithm, "SHA-256") == 0)) {
if (digest_func(ha1, "%s:%s:%016llx", ha1, auth_data->nonce, auth_data->cnonce) <= 0) {
goto _digest_exit;
}