Log when response arrives (#17488)
Looking at #17485, I noticed we don't log when a request finishes, making the log harder to read than necessary. Example new log message: ``` TRACE Received response for revalidation request with status 304 Not Modified for: https://pypi.org/simple/idna/ ```
This commit is contained in:
@@ -541,6 +541,11 @@ impl CachedClient {
|
|||||||
.instrument(info_span!("revalidation_request", url = url.as_str()))
|
.instrument(info_span!("revalidation_request", url = url.as_str()))
|
||||||
.await
|
.await
|
||||||
.map_err(|err| Error::from_reqwest_middleware(url.clone(), err))?;
|
.map_err(|err| Error::from_reqwest_middleware(url.clone(), err))?;
|
||||||
|
trace!(
|
||||||
|
"Received response for revalidation request with status {} for: {}",
|
||||||
|
response.status(),
|
||||||
|
url
|
||||||
|
);
|
||||||
|
|
||||||
// Check for HTTP error status and extract problem details if available
|
// Check for HTTP error status and extract problem details if available
|
||||||
if let Err(status_error) = response.error_for_status_ref() {
|
if let Err(status_error) = response.error_for_status_ref() {
|
||||||
@@ -604,13 +609,18 @@ impl CachedClient {
|
|||||||
cache_control: CacheControl<'_>,
|
cache_control: CacheControl<'_>,
|
||||||
) -> Result<(Response, Option<Box<CachePolicy>>), Error> {
|
) -> Result<(Response, Option<Box<CachePolicy>>), Error> {
|
||||||
let url = DisplaySafeUrl::from_url(req.url().clone());
|
let url = DisplaySafeUrl::from_url(req.url().clone());
|
||||||
trace!("Sending fresh {} request for {}", req.method(), url);
|
debug!("Sending fresh {} request for: {}", req.method(), url);
|
||||||
let cache_policy_builder = CachePolicyBuilder::new(&req);
|
let cache_policy_builder = CachePolicyBuilder::new(&req);
|
||||||
let mut response = self
|
let mut response = self
|
||||||
.0
|
.0
|
||||||
.execute(req)
|
.execute(req)
|
||||||
.await
|
.await
|
||||||
.map_err(|err| Error::from_reqwest_middleware(url.clone(), err))?;
|
.map_err(|err| Error::from_reqwest_middleware(url.clone(), err))?;
|
||||||
|
trace!(
|
||||||
|
"Received response for fresh request with status {} for: {}",
|
||||||
|
response.status(),
|
||||||
|
url
|
||||||
|
);
|
||||||
|
|
||||||
// If the user set a custom `Cache-Control` header, override it.
|
// If the user set a custom `Cache-Control` header, override it.
|
||||||
if let CacheControl::Override(header) = cache_control {
|
if let CacheControl::Override(header) = cache_control {
|
||||||
|
|||||||
Reference in New Issue
Block a user